search

skelterjohn / go.matrix

linear algebra for go
Other
338 stars 72 forks source link

matrix norms/determinant #5

Open kshedden opened 11 years ago

kshedden commented 11 years ago

I believe that the OneNorm and InfinityNorm functions are implemented incorrectly.

The OneNorm should be the sum of absolute values of the elements of the matrix.

The InfinityNorm should be the maximum absolute value of the elements of the matrix.

Also, it would be helpful to have a function that provides the log determinant, since the determinant will blow up for moderate or large matrix sizes.

skelterjohn commented 11 years ago

Oops, you're right, I switched those!

Feel free to make a pull request for LogDet()

On Mon, Jan 21, 2013 at 12:31 AM, kshedden notifications@github.com wrote:

I believe that the OneNorm and InfinityNorm functions are implemented incorrectly.

The OneNorm should be the sum of absolute values of the elements of the matrix.

The InfinityNorm should be the maximum absolute value of the elements of the matrix.

Also, it would be helpful to have a function that provides the log determinant, since the determinant will blow up for moderate or large matrix sizes.

— Reply to this email directly or view it on GitHubhttps://github.com/skelterjohn/go.matrix/issues/5.

kshedden commented 11 years ago

John,

Thanks, and thanks for your work on this project.

Best,

Kerby

On Mon, Jan 21, 2013 at 6:58 AM, John Asmuth notifications@github.comwrote:

Oops, you're right, I switched those!

Feel free to make a pull request for LogDet()

On Mon, Jan 21, 2013 at 12:31 AM, kshedden notifications@github.com wrote:

I believe that the OneNorm and InfinityNorm functions are implemented incorrectly.

The OneNorm should be the sum of absolute values of the elements of the matrix.

The InfinityNorm should be the maximum absolute value of the elements of the matrix.

Also, it would be helpful to have a function that provides the log determinant, since the determinant will blow up for moderate or large matrix sizes.

— Reply to this email directly or view it on GitHub< https://github.com/skelterjohn/go.matrix/issues/5>.

— Reply to this email directly or view it on GitHubhttps://github.com/skelterjohn/go.matrix/issues/5#issuecomment-12494800.

taylorchu commented 9 years ago

btw, the norm in this package uses vector norm not matrix norm.

taylorchu commented 9 years ago

fixed in #15