GoogleCodeExporter
commented
8 years ago About this issue and issue 145.
I have the same problem with version 0.7
I took a look at the source code and found the bug.
In the home activity (HomeActivity.java), you compute the total sleep time (l.
92-99) and then you take the average by dividing by the number of sleep (l.
102).
This is fine as long as there is no overflow.
Here it is the case. You sum up the sleep time (in ms) in an int, l. 88 :
int avgDuration = 0;
As the maximum value for an int is 2^31-1 (2147483647), if you sleep an average
of 8 hours (28800000ms), it gives you a correct average for the first
2147483647/28800000 ~= 74 nights. After that the value is bogus.
A quick simple fix is to declare avgDuration as a long in line 88 :
long avgDuration = 0;
It is even better as SleepRecord.getTimespanText() takes a long as first
parameter so you will avoid a cast. You might consider using a long for
avgFellAsleep as well.
With a long, assuming an average of 8 hours per night, one could sleep
(2^63-1)/28800000 ~= 320 255 973 501 nights, so the average will be accurate
during more than 800 000 000 years!Original comment by nicolabr...@gmail.com on 30 Jun 2011 at 3:06
Original issue reported on code.google.com by
criscoa...@gmail.comon 24 May 2011 at 3:55