search

skent259 / crapssim

Simulator for craps with various betting strategies
MIT License
28 stars 13 forks source link

Require point off for Pass Line, don't Pass, etc. #4

Closed amortization closed 2 years ago

amortization commented 2 years ago

This handles the TODO for requiring that for Pass Line and Don't Pass Line the point must be off and for Come and Don't Come the point must be on.

amortization commented 2 years ago

I rebased this from dev (#3) so once those changes are accepted this will only include the current relevant changes.

amortization commented 2 years ago

I switched the base branch to master and then back to dev in order for the Files Changed to update with the rebase from the commits already made in dev (https://stackoverflow.com/questions/16306012/github-pull-request-showing-commits-that-are-already-in-target-branch.) So now I think that the only changes in here are the changes to can_be_places_point_on/off that make it a dictionary as opposed to two boolean variables. @skent259 I think that we're just looking for some guidance on the comment surrounding player default strategies and then this one should be good to merge.

skent259 commented 2 years ago

Thanks, I couldn't figure out how to see just the new changes.

Can we try the idea of making bet allowed a method? If it's too difficult now, I think the current changes are still an improvement but I'd suggest changing bet_allowed to bet_allowed_when

skent259 commented 2 years ago

Closing in favor of #12