`mi_df()` keeps all instance_labels after subsetting

skent259 / mildsvm

Multiple Instance Learning with Distributions, SVM

Other

3 stars 0 forks source link

`mi_df()` keeps all instance_labels after subsetting #52

Closed skent259 closed 2 years ago

skent259 commented 2 years ago

Need to adjust the [ method for mi_df() to also subset the 'instance_label' attribute

skent259 commented 2 years ago

Make sure to test with dplyr::select() and dplyr::filter()

skent259 commented 2 years ago

Resources that go into the depths of R typing:

https://vctrs.r-lib.org/reference/howto-faq-coercion-data-frame.html

This sort of implementation might be necessary/useful going forward.

skent259 commented 2 years ago

Mostly fixed with #53. Still doesn't work with dplyr::filter(), but this will require more detailed understanding of those methods and probably overwriting them explicitly.

While solving this issue, I'm thinking that it might be beneficial to have the mi_df and mild_df classes in a separate package. This would allow easier extension in the R community if they build research methods for multiple instance data frames, and separate out the documentation.