search

skepickle / foundryvtt-gaming-table-player

A module for FoundryVTT to allow for control of a utility-player logged in via a gaming table.
Creative Commons Attribution 4.0 International
3 stars 3 forks source link

Draw rectangle on GM's view to indicate bounds of table view #25

Closed skepickle closed 8 months ago

skepickle commented 8 months ago

Implement this drawing based on implementation in PR #21, submitted by @misthero.

skepickle commented 8 months ago

The implementation of this in PR #21 puts the bounding box onto canvas.stage, which seems to be shown on every scene. I'm trying to figure out a better way to do this so that it's specific to the actual scene being shown on the gaming table and isn't displayed on other scenes.

misthero commented 8 months ago

yep that is a basic implementation,you just need to hide it from canvas if the vtt character is on different scene,or if the scene the gm is looking at is not the current active scene. you could just change its visibility property to false.

also it lacks a method to remove the rectangle if the vtt player is disconnected.

On Sun, Mar 17, 2024, 00:12 Skepickle @.***> wrote:

The implementation of this in PR #21 https://github.com/skepickle/foundryvtt-gaming-table-player/pull/21, puts the bounding box onto canvas.stage, which seems to be shown on every scene. I'm trying to figure out a better way to do this so that it's specific to the actual scene being shown on the gaming table and isn't displayed on other scenes.

— Reply to this email directly, view it on GitHub https://github.com/skepickle/foundryvtt-gaming-table-player/issues/25#issuecomment-2002176337, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA36GETXAZZDI5SYIKIDVVLYYTGWVAVCNFSM6AAAAABEXBENHCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGE3TMMZTG4 . You are receiving this because you were mentioned.Message ID: @.***>

skepickle commented 8 months ago

@misthero checkout the Draft PR #27... I think I've made a clean solution, but let me know if you have any suggestions.

misthero commented 8 months ago

yes, I think that removing the layer children and not adding again based on the right condition should work too. not tested, but the code looks right.