Potential Bug? "Back" returns to page 1

sketch-city / harvey-api

Harvey Needs API

http://harveyneeds.org

GNU General Public License v3.0

23 stars 39 forks source link

Potential Bug? "Back" returns to page 1 #104

Closed meremaines closed 6 years ago

meremaines commented 7 years ago

Idea from Cheryl:

After a user submits an update to any record, the record's summary page shows three links at the bottom: update, back, and archive. After clicking "back," users expect to return to the most recently viewed page of the list, but instead, "back" returns you to the very first page of the list, requiring you to click through all the pages again to pick up where you left off.

rogerroelofs commented 7 years ago

This is fixed in the irma repo it is just adding 'saveState' to app/views/shared/_table.html.erb

jwo commented 7 years ago

I think back-merging the saveState from irma-api is the right way to go for all of our endpoints in v1 (and also then in v2)

rogerroelofs commented 7 years ago

saveState may be doing more than we really need since it also saves the column info and we don't allow users to hide / show columns. See https://github.com/Irma-Response/irma-api/pull/43 for updates that might be useful.