sketch-hq / nicene

Additional Credo checks
MIT License
39 stars 7 forks source link

Depend on credo minor instead of patch version #14

Closed AlphaHydrae closed 4 years ago

AlphaHydrae commented 4 years ago

The current dependency on credo ~> 1.2.0 makes it hard to use other plugins:

$> mix deps.get
Resolving Hex dependencies...

Failed to use "credo" (version 1.4.0) because
  credo_contrib (version 0.2.0) requires ~> 1.0
  credo_envvar (version 0.1.4) requires ~> 1.0
  credo_naming (version 0.6.1) requires ~> 1.4
  nicene (version 0.5.0) requires ~> 1.2.0
  mix.lock specifies 1.4.0

The test suite seems to pass with the latest version of credo.

AlphaHydrae commented 4 years ago

Oh, missed https://github.com/sketch-hq/nicene/pull/11 which also does this. Sorry about the spam.