search

sketch-hq / sketch-assistants

Monorepo containing the official Sketch Assistants, along with utility functions and types for Sketch Assistant development.
MIT License
45 stars 11 forks source link

feat/#170 add rules and tests for bitmaps #172

Closed konki-vienna closed 3 years ago

konki-vienna commented 3 years ago

Added some code to check if bitmaps that don't use a layer style have no default styling (such as fills, borders, shadows, inner shadows, blur or colour adjust). If a bitmap layer has a non-default styling, a violation is triggered. Added tests to cover that.

bomberstudios commented 3 years ago

Thanks a lot for this (and extra karma points for including tests! : )

jedrichards commented 3 years ago

Looks good to me too! Shall we merge @christianklotz?

jedrichards commented 3 years ago

@christianklotz It'd be nice to release this soon, but to do that we'll need to manually add a changeset for this in a quick new PR.