sketchbooks99 / PRayGround

GPU ray tracing framework using NVIDIA OptiX 7 and 8
MIT License
40 stars 2 forks source link

Update with OptiX 7.5 raises some issues #10

Closed bipul-mohanto closed 1 year ago

bipul-mohanto commented 1 year ago

Hi @sketchbooks99 ,

I was trying to update your prayground library with latest OptiX7.5. Few minor issues are there, I could solve. Unfortunately, the third issue I could not figure out how to solve. It is in the prayground/optix/denoiser.cpp:242:33 , m_params.denoiseAlpha = 0.

// prayground/core/stream_helpers.h
-OPTIX_COMPILE_DEBUG_LEVEL_LINEINFO
+OPTIX_COMPILE_DEBUG_LEVEL_MINIMAL

// prayground/optix/module.cpp
-OPTIX_COMPILE_DEBUG_LEVEL_LINEINFO
+OPTIX_COMPILE_DEBUG_LEVEL_MINIMAL

// prayground/optix/denoiser.cpp

/home/luciano/Desktop/rt_mpi_viewer/optix_path_lib/prayground/optix/denoiser.cpp: In member function ‘void prayground::Denoiser::init(const prayground::Context&, const prayground::Denoiser::Data&, uint32_t, uint32_t, bool, bool)’:
/home/luciano/Desktop/rt_mpi_viewer/optix_path_lib/prayground/optix/denoiser.cpp:242:33: error: invalid conversion from ‘int’ to ‘OptixDenoiserAlphaMode’ [-fpermissive]
  242 |         m_params.denoiseAlpha = 0;

If you have some time, please look at the issue.

sketchbooks99 commented 1 year ago

Hi @bipul-mohanto

I've fixed your reported errors, and please look at related commit :) It was due to the slight update of API on 7.5.0.

bipul-mohanto commented 1 year ago

Thank you so much. Now the repo is working fine with the latest OptiX 7.5.