[BUG]

[bipul-mohanto]

@sketchbooks99

Hi,

Thanks for the repository. I am using Ubuntu 22.04 LTS, OptiX 7.4, Driver version 515.65.01, CUDA 11.7, CLion as an IDE.

I find some errors with util.h file during compilation,

/home/highvive1/Desktop/PRayGround/prayground/core/util.h:188:56: error: expected primary-expression before ‘)’ token
  188 |         Message(MSG_WARNING, ss.str(), msg, __VA_ARGS__);       \
      |                                                        ^
/home/highvive1/Desktop/PRayGround/prayground/shape/trianglemesh.cpp:110:13: note: in expansion of macro ‘PG_LOG_WARN’
  110 |             PG_LOG_WARN("Two or more number of indices have been already set.");
      |             ^~~~~~~~~~~
/home/highvive1/Desktop/PRayGround/prayground/shape/trianglemesh.cpp: In member function ‘prayground::TriangleMesh::Data prayground::TriangleMesh::getData()’:
/home/highvive1/Desktop/PRayGround/prayground/core/util.h:180:55: error: expected primary-expression before ‘)’ token
  180 |         Message(MSG_NORMAL, ss.str(), msg, __VA_ARGS__);   

So, If I comment the PG_LOG/ PG_LOG_WARN in the program, it works fine. Very probably the __VA_ARGS__ is creating the problem. Could you please check?

[sketchbooks99]

Hi @bipul-mohanto

Thank you for reporting the issue. It was due to slight difference between linux/windows environment 😞 I've fixed those errors, and pushed to master branch. But it was tested on WSL not pure linux, so please let me know if you face to other bugs.

[bipul-mohanto]

ありがとうございます。 It is all working fine now. I always admire your work and learning a lot from you. Few questions:

• The pathtracing example you have developed, is that the uni-directional path tracing algorithm same as OptiX SDK included path tracing example? Of course you did a huge modification.
• Would it be possible sharing the resources folder for your project?

[sketchbooks99]

@bipul-mohanto

I'm glad it works well.

• Unfortunately, my pathtracing example differs from SDK's path tracing example, in the part of explicit light sampling. My example uses only simple monte-carlo integration, and there is no light sampling to fasten the convergence. But, I understand that I should implement it for better demonstration of my library. I'd appreciate your patience as it might take some time.
• Yes. May I send it through email in your bio?

[bipul-mohanto]

Thank you once again.

• I would really appreciate it if you could kindly send the resources at bipul.mohanto@yahoo.com. I have downloaded most of it from different sources, but it is always better working with the original.
• My research actually involved in foveated path tracing, and your library is really wonderfully fitting my purpose. I would like to continue working on your library, let's see if I can contribute something to it.
• I just made a variable sampling in-between two regions.

[sketchbooks99]

Nice! I really enjoy and be glad to see your interesting work! I hope you will go well. And please let me know if you publish any papers or works. It will be big motivation to develop my library👍