sketchfab / godot-plugin

MIT License
109 stars 20 forks source link

Complete browsing #3

Closed RandomShaper closed 6 years ago

RandomShaper commented 6 years ago

I've not been able to finish importing today.

Browsing is complete, but filtering by face count and categories isn't working. Any clues? Please look at the Godot console window to see what request are being sent.

This is how it looks currently: imagen

AurL commented 6 years ago

Yes, I think I found the issues:

I hope it helps!

AurL commented 6 years ago

Also you don't need &file_format=gltf I don't have any result when I search for a term, probably because of this parameter.

RandomShaper commented 6 years ago

@AurL, thanks! I've updated this PR after applying what you told and it seems to be working.

Furthermore, I've changed the code to use the /search endpoint in all cases. Formerly, I was using /models when no search query had been entered into the search box.

Please note that, in order to keep a clean Git history, I tend to rewrite branch's history, so a single pull won't be enough to update your local copy. Please ignore this if you already know this Git stuff well.

RandomShaper commented 6 years ago

Please wait before merging since I am adding a commit that changes how categories are managed. Keeping that unsquashed to have the code for multicategories in the repo history in case it's needed sometime.

RandomShaper commented 6 years ago

Pushed!

RandomShaper commented 6 years ago

I've added one more commit, to display the user avatar.

I'll leave this PR alone now to start adding the remaining features on new branches.