sketchfab / unity-plugin

296 stars 39 forks source link

Issue with latest Unity version 2021.3.6f1 #18

Open SynthKittenDev opened 2 years ago

SynthKittenDev commented 2 years ago

Hi there,

Upon installing this plugin on Unity 2021.3.6f1, I get this error. I have tried this in a fresh 3D template, 3D URP template and 3D HDRP template. The same error in them all.

I'm certain it's due to a new Newtonsoft.Json version, but I don't know how to roll back to 12.0.0.

Screenshot_15 0

VoxelChunk commented 2 years ago

You can find the fix for this Here, I just fixed it myself thanks to another post down in the forums a bit.

SynthKittenDev commented 2 years ago

You can find the fix for this Here, I just fixed it myself thanks to another post down in the forums a bit.

Hi there, this version doesn't work for me either because it's a different error then the others people were having.

I believe it is due to the fact newtonsoft has updated in this version of Unity and the Sketchfab plugin can't use it since it's not the correct 12.0.0.0 version. Older releases haven't fixed it for me.

I get the same errors: Screenshot_16

EmreErdogan commented 2 years ago

I have the same issue with Unity 2021.3.7f1 on macOS Monterey 12.2.1 and SketchfabForUnity-v1.2.2

Screen Shot 2022-07-31 at 14 28 55
endasil commented 2 years ago

I downloaded the source code from https://github.com/sketchfab/UnityGLTF.git, swapped out the newtonsoft 12 dll in the GLTFSerialization project for 13, build the dll and replaced the old one and got it to work in 2021.3.7. If you want you can grab my package see if it works for you.

https://github.com/endasil/SketchfabForUnityUsingNewtonSoft13/raw/main/SketchfabForUnityUsingNewtonSoft13.unitypackage

tkd-itsuki commented 2 years ago

@endasil It worked. You should create a pull request for this fix to help everyone using unity 2021.

endasil commented 2 years ago

I do not have access to push to that repo, so I can't do that sadly.

TWiG-US420 commented 2 years ago

this fixed it ... thank you