search

sketchfab / unity-plugin

291 stars 39 forks source link

Ionic.Zip conflict after importing SketchfabForUnity v.1.2.0 into Unity 2021.1.6 #7

Open kylereinfeld opened 3 years ago

kylereinfeld commented 3 years ago

I'm getting four similar console errors after import. Example:

Library\PackageCache\com.unity.visualscripting@1.5.2\Editor\VisualScripting.Core\Utilities\BackupUtility.cs(26,34): error CS0433: The type 'ZipFile' exists in both 'Ionic.Zip.Unity, Version=1.9.1.9000, Culture=neutral, PublicKeyToken=null' and 'Ionic.Zip, Version=1.9.1.8, Culture=neutral, PublicKeyToken=edbe51ad942a3f5c'

I tried importing the package with IonicZip unchecked, but that results in its own issues. Is there an easy workaround for this?

AurL commented 3 years ago

Thanks @kylereinfeld for reporting. The log shows that the new VisualScripting feature also includes the Ionic.Zip but with a different version, which collide with the one distributed with our plugin. There might be some adjustements to do in the code to make it fit with the Unity's default version.

We are going to investigate and provide a workaround before fixing it 👍

kylereinfeld commented 3 years ago

Thanks @AurL. As soon as there's a workaround please feel free to let me know!

michaelmarkman commented 2 years ago

Any updates on this? For now, I've disabled Visual Scripting in the package manager, which seems to be working.

AurL commented 2 years ago

@michaelmarkman It looks like we didn't come back to this when fixing the other dependency collision. I don't reproduce the issue on Unity 2021.1.19f1 (with Visual Scripting 1.6.1), which versions do you have on your side ?

It also works for 2021.2.6f1 (with Visual Scripting 1.7.5), but I might be missing a detail. Could you share your console error(s) to see if there is any other detail ?