search

sketchpacks / bug-reports

Noticed a bug? Report it here.
https://www.sketchpacks.com
6 stars 2 forks source link

Plugin Versions Don't Match #1

Open connerdrew opened 7 years ago

connerdrew commented 7 years ago

The versions of plugins installed via Sketchpacks doesn't match what is installed within Sketch itself. There also seems to be more recent versions on Github than what's being shown in Sketchpacks.

adamkirkwood commented 7 years ago

@connerdrew This was a tricky one.

We've noticed that there are some plugins with invalid manifest.json files which prevents our API from parsing it entirely.

I believe the proper fix here would be to first make the plugins have valid manifest.json files first.

Do you know which plugins you've observed with versions mismatching installed vs what is being shown?

adamkirkwood commented 7 years ago

@willdavis Let's create a list of all the plugins we've indexed thus far. I'll go ahead and send each plugin a pull request with fixes to their manifest.json files.

mfouquet commented 7 years ago

I had this problem as well with my plugin. It kept showing up with zero info from the manifest and I couldn't figure out why since it had all the correct details in it. Then my brain sputtered to a start and I figured I should try running it through a json validator. Problem solved. All this to say, it might be worth having a note on the GitHub integration page about running the the manifest through a linter/validator to clear up any errors.

BTW, love the app, works great 👍

niittymaa commented 7 years ago

It seems that AnimateMate have this problem even JSON seems to be valid.

Sketchpacks shows version 0.1.8 but the current version is 0.1.9 in manifest file.

I'm not sure where's the problem...

Mythrendel commented 7 years ago

I'm having this issue as well for my Button Symbols plugin. The version says v1.2.1 is latest of 3 versions but v1.2.3 is actually the latest version. I have officially published v1.2.2 and v1.2.3 as releases on Github and the latest code is part of the master branch.

The issue affects both the sketchpacks.com site and the version shown in the menubar application.

The JSON in the manifest appears valid.

kannonboy commented 7 years ago

Ditto with Jira Cloud for Sketch, valid manifest afaict, but version is showing up as 0.0.0.

Note that this did have an invalid manifest in the past, so perhaps that triggered the issue and now it's no longer updating?