Closed sketchpunk closed 10 years ago
Why not just use the embedded metadata, if it has it.
If you have some examples of the meta data, I can possibly make that one of the options. None of my comics have that data.
I can send you some comics, but you can also download a copy of Comictagger:
https://code.google.com/p/comictagger/
And tag your comic with both CBL and CR metadata.
If you'd rather I send you a file, just tell me where to send it.
On Mon, Jan 6, 2014 at 12:44 PM, sketchpunk notifications@github.comwrote:
If you have some examples of the meta data, I can possibly make that one of the options. None of my comics have that data.
— Reply to this email directly or view it on GitHubhttps://github.com/sketchpunk/opencomicreader/issues/25#issuecomment-31668868 .
I have a copy of ComicRack right now and it will sort by metadata. I can browse by Publisher->Series. Very convenient.
I'll give the app a try and see what it does. Hopefully it's just an xml or something readable that's put inside the zip/rar file. I'm thinking about rebuilding the sync from scratch, so I should be able to implement the meta stuff in the process.
The ComicRack metadata is an XML inside the ZIP. ComicBookLover metadata is JSON data embedded in the comment field of the ZIP file.
ComicTagger will also convert your CBRs to CBZ files with one click. Comictagger can't write metadata to CBR files without yo having the RAR executable to write the data. It's better to convert to CBZ.
Just an FYI.
On Mon, Jan 6, 2014 at 12:54 PM, sketchpunk notifications@github.comwrote:
I'll give the app a try and see what it does. Hopefully it's just an xml or something readable that's put inside the zip/rar file. I'm thinking about rebuilding the sync from scratch, so I should be able to implement the meta stuff in the process.
— Reply to this email directly or view it on GitHubhttps://github.com/sketchpunk/opencomicreader/issues/25#issuecomment-31669758 .
Extracting the XML from either zip or rar should be easy enough, but Have no clue how to read embedded data from a file in android. Quick googling shows no examples, might be searching with the wrong keywords.
Btw, I keep all my comics in Zip, its a much more portable format then rar (zip is built into everything)... I have no clue why people use rar so much, 7Zip is a better compression and its open source, rar is just... eeeeh.
ComicRack XML based metadata support would be more than adequate. I'm assuming if you read metadata and use it to sort comics, you're going to need to keep some kind of database.
I agree, rar support is very annoying to build into an application. I have a file manager in the play store and including rar support will add a great deal of bulk to the application.
It won't add to much bulk to the app in all honesty. Its a massive pain in the ass to build from unrar source, then there is small changes you need to do to get it compiling on android. https://github.com/sketchpunk/jniunrar, you can use my other project as a stepping stone.
You can probably do what I did, Work on JNIUnrar separately and when all done, just copy the compiled SO files (android dlls) over to your file manager, plus the JNI java file that bridges C and Java together. This way you don't need NDK installed and setup to compile your main android app. I did this becomes I did not want to over complicate the comic app with all the C and JNI stuff, plus make it easier for other people to work on comic reader without worrying about the low level bs.
I also have another repository trying to get 7Zip working on android, but so far no good. That would be the best one to get working since you'll get Zip, Rar, 7z plus a few other archives working for your app with one dll library file.
alrighty. I pretty much finished up this wave of changes and the new app is up on the play store. For the next month or two I won't have any time to really do any big updates, but I'll be around for bug fixes or any pull requests. Thanks everyone for your feedback.
When I get back, my next wave of changes will be centered around updating the viewing aspect of the app. Fix up the gestures, etc. I'll make another issue with what I have planned and where people can chime in. This worked out pretty well, so that's probably how I'll format my all my enhancements in the future. If it wasn't for doing it this way, I would of never put together the comicrack meta support. So thanks again everyone.