sketchpunk / opencomicreader

Comic/Manga viewer for Android devices.
95 stars 37 forks source link

Suggestion: Animated Transitions and Navigation #27

Closed ghost closed 10 years ago

ghost commented 10 years ago

Thanks for this app, it is looking great and is certainly on my fast track to being my default reader. That said I hope a couple features will show up soon in future revisions:

1) Animated Transition. It is a little jarring to slide my finger and the picture just changes. I personally do not think the animations need to be fancy just have the next or previous page slide in on a page turn.

2) In-comic navigation. The main thing needed here is a way to move to the previous/next comic from within the comic (other programs do this by tapping the upper left or right corners). It would also be nice to preview and jump directly to page in a comic.

Anyway like I said I am excited to this comic reader come on the scene. It is off to a great start and I look forward to it get better.

sketchpunk commented 10 years ago

Thanks, Glad you're enjoying the app. The next wave of improvements will be centered around the viewing aspect of the app. I already planned how to make moving to the next comic when done with the current one work. I just need move a few things around then use data paging to tell me whats the next/previous comics.

I was also thinking about doing that type of sliding effect since some gallery apps do that and I really like it. Just not sure how to go about doing it though. I recently read about feature on android that allows a developer to do a physical cache of an image where right now I cache them in memory which sometimes can give people out of memory errors. So I can at least be able to hold 3 images that I can use. I paint the image onto a canvas and use a matrix object to transform it and repaint on pinch to zoom. One thought of doing that effect would be to paint 2 images on the canvas then use the matrix to animate it from one to the other. Not sure if this is the best way to do it? If you can find some great tutorials to do this type of animation or other android open source apps that do that sort of thing, it'll definitely help me do that.

I still have lots to learn when it comes to programming effects :) , especially on how to use the matrix stuff.

danielniccoli commented 10 years ago

@sketchpunk Why do you close this issue request when you like to see this implemented, too?

sketchpunk commented 10 years ago

oh, i was cleaning up requests and grouped many of them to the next wave of development i'm planning to start some point in march. here is the thread, https://github.com/sketchpunk/opencomicreader/issues/29

danielniccoli commented 10 years ago

@sketchpunk, it's best practice to leave those issues open unless they are fixed, invalid, not reproducible or a won't-fix. If you want to group them, use Milestones or references (possibly with task lists).

Cheers and keep up the good work :thumbsup:

danielniccoli commented 10 years ago

Oh, and it's a good practice to have one issue for one bug/request. Keep it granular so devs and users can keep track of progress. :smile:

sketchpunk commented 10 years ago

Didn't work out so well, people kept adding the same issues with different wordings, and emailing me repeats. Last version i grouped everything under the banner "Next Wave of Enhancements", it made it easier to manage and people just commented about other ideas that can be added into the list. It worked out better this way. I work as a dev full time, we do milestones, issues etc, that stuff works really well when its a team working together. Since I'm on my own, and every once in awhile someone gives me a patch, its better to keep things slim.