sketchpunk / opencomicreader

Comic/Manga viewer for Android devices.
95 stars 37 forks source link

FC when accessing settings in v0.3 #56

Closed didierm closed 9 years ago

didierm commented 9 years ago

(appearantly, this issue has also been reported in the Reviews section in the Play Store)

Removed previous version (+data & cache) ; fresh install of v0.3. Crash when accessing 'Settings' menu option :

I/ActivityManager(  446): START u0 {cmp=com.sketchpunk.ocomicreader/.PrefActivity} from pid 23635
D/dalvikvm(23590): GC_CONCURRENT freed 403K, 70% free 4589K/15004K, paused 4ms+2ms, total 37ms
D/AndroidRuntime(23635): Shutting down VM
W/dalvikvm(23635): threadid=1: thread exiting with uncaught exception (group=0x41bb6ba8)
E/AndroidRuntime(23635): FATAL EXCEPTION: main
E/AndroidRuntime(23635): Process: com.sketchpunk.ocomicreader, PID: 23635
E/AndroidRuntime(23635): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.sketchpunk.ocomicreader/com.sketchpunk.ocomicreader.PrefActivity}: java.lang.RuntimeException: Subclasses of PreferenceActivity must override isValidFragment(String) to verify that the Fragment class is valid! com.sketchpunk.ocomicreader.PrefActivity has not checked if fragment com.sketchpunk.ocomicreader.PrefActivity$SyncPreferenceFragment is valid.
E/AndroidRuntime(23635):    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2195)
E/AndroidRuntime(23635):    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2245)
E/AndroidRuntime(23635):    at android.app.ActivityThread.access$800(ActivityThread.java:135)
E/AndroidRuntime(23635):    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1196)
E/AndroidRuntime(23635):    at android.os.Handler.dispatchMessage(Handler.java:102)
E/AndroidRuntime(23635):    at android.os.Looper.loop(Looper.java:136)
E/AndroidRuntime(23635):    at android.app.ActivityThread.main(ActivityThread.java:5017)
E/AndroidRuntime(23635):    at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime(23635):    at java.lang.reflect.Method.invoke(Method.java:515)
E/AndroidRuntime(23635):    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:779)
E/AndroidRuntime(23635):    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:595)
E/AndroidRuntime(23635):    at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:132)
E/AndroidRuntime(23635):    at dalvik.system.NativeStart.main(Native Method)
E/AndroidRuntime(23635): Caused by: java.lang.RuntimeException: Subclasses of PreferenceActivity must override isValidFragment(String) to verify that the Fragment class is valid! com.sketchpunk.ocomicreader.PrefActivity has not checked if fragment com.sketchpunk.ocomicreader.PrefActivity$SyncPreferenceFragment is valid.
E/AndroidRuntime(23635):    at android.preference.PreferenceActivity.isValidFragment(PreferenceActivity.java:898)
E/AndroidRuntime(23635):    at android.preference.PreferenceActivity.switchToHeaderInner(PreferenceActivity.java:1179)
E/AndroidRuntime(23635):    at android.preference.PreferenceActivity.switchToHeader(PreferenceActivity.java:1219)
E/AndroidRuntime(23635):    at android.preference.PreferenceActivity.onCreate(PreferenceActivity.java:564)
E/AndroidRuntime(23635):    at com.sketchpunk.ocomicreader.PrefActivity.onCreate(PrefActivity.java:29)
E/AndroidRuntime(23635):    at android.app.Activity.performCreate(Activity.java:5231)
E/AndroidRuntime(23635):    at de.robv.android.xposed.XposedBridge.invokeOriginalMethodNative(Native Method)
E/AndroidRuntime(23635):    at de.robv.android.xposed.XposedBridge.handleHookedMethod(XposedBridge.java:631)
E/AndroidRuntime(23635):    at android.app.Activity.performCreate(Native Method)
E/AndroidRuntime(23635):    at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1087)
E/AndroidRuntime(23635):    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2159)
E/AndroidRuntime(23635):    ... 12 more
W/ActivityManager(  446):   Force finishing activity com.sketchpunk.ocomicreader/.PrefActivity
W/ActivityManager(  446):   Force finishing activity com.sketchpunk.ocomicreader/.LibraryActivity
D/hwcomposer(  121): fb1 open!
D/hwcomposer(  121): fb1 realy close!
W/ActivityManager(  446): Activity pause timeout for ActivityRecord{429c2200 u0 com.sketchpunk.ocomicreader/.PrefActivity t165 f}
D/dalvikvm(22472): GC_CONCURRENT freed 1598K, 87% free 5218K/37472K, paused 3ms+6ms, total 36ms
V/RenderScript( 4833): 0x74141cf0 Launching thread(s), CPUs 4
sketchpunk commented 9 years ago

ok, looks like this might be a new security thing I was not aware off when using fragments. Found a simple fix for your problem on this forum. I'll apply it to the source soon.

http://stackoverflow.com/questions/20954072/when-androids-isvalidfragment-from-preferenceactivity-gets-called

sketchpunk commented 9 years ago

new update published. Should fix this error.

didierm commented 9 years ago

Confirmed fixed in 0.3.1beta ; thanks !