Open jhbuchanan45 opened 3 years ago
Thank you for this PR!
Hi @jhbuchanan45 this is really great stuff. I've tried merging your changes into my fork of this app, but I'm running into issues with (I assume) the modal for editing HTTP headers. Any time I try to edit an existing one, or save a new one, the screen goes white, and I have to close/refresh the app which then looses the changes I've made. It happens every time, and using Node 15 as recommended, or Node 17, I am getting the same result.
I'm pretty unfamiliar with using electron so don't really know where to begin with this. Any chance you'd be able to look into it or give me a pointer?
"electron": "^11.0.0"
to specify version for electron-buildernpm/yarn run watch
command which useswebpack --watch
to enable debugging while working faster (replacement for webpack dev server which doesn't currently work with the new config)Fixes #188, #175 and any others with 'Harfbuzz version too old (1.2.7)' error Fixes #179 (Not seeing that error anyway on any platforms when building)
I have not tested freshly built installers for mac or win, only on Linux. To resolve these errors, a new version would have to be released with newly built file attached. I have also written a github workflow for this which uses 'samuelmeuli/action-electron-builder@v1.6.0' to invoke electron-builder inside the native OS for linux/windows/mac builds and automatically drafts a release with the files uploaded (I think it uses electron-builder release under the hood) when 'v*' tags are pushed to the repo
NodeJS v16 currently doesn't work with electron builder, (see https://github.com/electron-userland/electron-builder/issues/5668) use v15 or older to build