search

skhatri / grunt-nexus-deployer

Nexus Artifact deployer from grunt against snapshot and release repositories.
MIT License
13 stars 69 forks source link

fix mkdir when parent directory does not exist #27

Closed ghost closed 7 years ago

ghost commented 8 years ago

Hi,

At our company our Jenkins builds started failing after we updated grunt-nexus-deployer from 0.0.4 to 0.1.0. (Update: That, and some other changes. I realised later that it wasn't the upgrade of grunt-nexus-deployer on its own. Still, the fix remains valid.)

It threw an error if any of the parent directories does not exist, e.g. "ENOENT: no such file or directory, mkdir 'build/pom'" if 'build' directory does not exist.

I added mkdirp to make it recursively add directories. After this fix our builds were successful again :).

arnoudb commented 8 years ago

+1 nice fix

ghost commented 8 years ago

@skhatri grunt-nexus-deployer has at the time of writing 4 open pull requests, 2 from a few months ago and another 2 from 2015. Also the builds are failing on npm peer dependency errors. Are you going to respond to the PRs, or do we need to consider this open source project as abandoned? In the latter case it would be nice to at least warn about it in your readme on github and npm.

prashantpalikhe commented 7 years ago

+1

Need this fix too. Can we get this merged soon?

skhatri commented 7 years ago

The build fails. Happy to merge if you send a working PR

arnoudb commented 7 years ago

@skhatri happy to see you are picking this up! Do you have an idea when this will be merged and published as a new version?

skhatri commented 7 years ago

Will do it by tomorrow. Will possibly merge all and fix any issues as they come along.

arnoudb commented 7 years ago

@skhatri thnx for the new release!

prashantpalikhe commented 7 years ago

🎉