NiallDelahunty commented 4 years ago

Hey! Thank you for creating this API using it for a college project! Couldn't get the balance to show up and found out the class 'balance cell' worked if 'pull-left' was changed to float left.

Thanks

codecov[bot] commented 4 years ago

Codecov Report

Merging #10 into master will decrease coverage by 16.46%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master      #10       +/-   ##
===========================================
- Coverage   84.14%   67.68%   -16.47%     
===========================================
  Files           5        5               
  Lines         164      164               
===========================================
- Hits          138      111       -27     
- Misses         26       53       +27

Impacted Files	Coverage Δ
pyleapcard/PyLeapCard.py	`55.78% <100.00%> (-16.85%)`	:arrow_down:
pyleapcard/CardOverview.py	`18.18% <0.00%> (-81.82%)`	:arrow_down:
tests/tests.py	`95.65% <0.00%> (-4.35%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0e88bd6...4c3f98f. Read the comment docs.

skhg commented 4 years ago

Hey @TechyBiologist !

Thanks very much for the PR and the nice feedback. I'll check up on this soon and merge it. I should probably add some tests here...

skhg commented 4 years ago

Note for anyone reading this later, please ensure you run pip install --upgrade pyleapcard to get the latest version and avoid this issue

skhg / pyleapcard

Balance cell class change #10

Codecov Report