skhzhang / time-based-themes

Automatically change Firefox's theme based on the time
MIT License
121 stars 13 forks source link

"Change themes based on the system theme" not working on macOS #11

Open skhzhang opened 4 years ago

skhzhang commented 4 years ago

Didn't work for me on macOS unfortunately, the system changed from light to dark automatically and automaticDark didn't pick up on it and stayed light. This is with the "Change themes based on the system theme" setting enabled

Originally posted by @derekschinke in https://github.com/skhzhang/time-based-themes/issues/8#issuecomment-626264274

chrisgross commented 4 years ago

I just did a quick test, and this does work as intended for me if I manually change system themes in Catalina's system preferences. I will have to wait until this evening to see whether it works during an automatic theme change or when opening my MacBook in the morning for the first time.

derekschinke commented 4 years ago

I think my issue may be that I'm using Shifty to change the theme automatically, and not relying on Apple's settings alone. This is because Apple's settings require the computer to be closed, or logged out, for the theme change to take place. Shifty changes the theme automatically with the computer still on. One would think that this is equivalent to manually changing themes in settings, but it may not be.

chrisgross commented 4 years ago

@derekschinke I am using f.lux to change the system theme at sunset and am having the same problem as you. This extension does not seem to respect this setting unless you manually set it in the system preferences, which is unfortunate. FWIW, the Dark Reader add-on handles this just fine, so it definitely can be done.

silverhallow commented 3 years ago

For me, it works when macOS automatically changes from light to dark. But if I turn my computer off when it's at dark mode and turn it on later when it's in light mode, my theme is still at the one I chose for dark mode. Toggling between the options in the "Daytime theme" dropdown applies those options for a bit, but it soon reverts back to the Nighttime theme.

xplosionmind commented 3 years ago

I'm using Shifty to change the theme automatically, and not relying on Apple's settings alone.

Same here, but I am using DarkModeBuddy (which is a great, game-changing little software and I strongly suggest you to check it out, btw) and the Firefox theme goes crazy.

As of right now, when I open Firefox, regardless of the theme MacOS has, it is in light mode. Nevertheless, while I use it, it is always in dark mode. I do not understand.

I am using Firefox 86 on MacOS 11

skhzhang commented 2 years ago

I also mentioned this on #22, but there are major issues with the "Change themes based on the system theme" option because the extension uses prefers-color-scheme to detect the system theme.

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1529323, Firefox will set prefers-color-scheme based on whatever theme is currently set. This causes issues with the extension which I'm still trying to work out.

skhzhang commented 2 years ago

I've made changes to the "Change themes based on the system theme" option on 1.4.0. Note you will need Firefox 95 or later for this version. Please let me know if the issue persists with 1.4.0.

Thanks!

Duckbilled commented 1 year ago

It doesn´t seem to work on my end (version 1.4.1), but maybe this has to do with me being on beta?

nose-gnome commented 1 year ago

Doesn't seem to work on Ubuntu/Linux with Gnome 43 either

KierPrev commented 1 year ago

Same in Kubuntu 23.04 in Firefox 111. If I reselect the option, the theme changes