skhzhang / time-based-themes

Automatically change Firefox's theme based on the time
MIT License
121 stars 13 forks source link

Extension Mozilla used at Tor Browser #41

Closed GreimersStefan closed 1 year ago

GreimersStefan commented 1 year ago

Issue: Tor Browser 12.0.3 (based on Mozilla Firefox 102.8.0esr) (64-bit), macOS 11.7.4 (20G1120) Big Sur. In the settings of automaticDark "Change themes based on the system theme" is activated. And "Do not change themes automatically (change only on startup and setup)". Now it's common for some page views to afford a white screen because the content can only be read on a white background. In your software this is impossible. Browsers like Apple Safari macOS have the app with toggle mode in the menu bar. Mozilla Firefox shows all extensions in the menu bar (?). Tor Browser doesn´t.

skhzhang commented 1 year ago

Hi @StefanAndPrviate ,

Are these two separate issues? For both, can you supply screenshots?

  1. Now it's common for some page views to afford a white screen because the content can only be read on a white background. In your software this is impossible.
  2. Browsers like Apple Safari macOS have the app with toggle mode in the menu bar. Mozilla Firefox shows all extensions in the menu bar (?). Tor Browser doesn´t.
GreimersStefan commented 1 year ago

Hi@skhzhang,

You developed your extension for Mozilla Firefox. I can't determine how this affects it. Your extension to Tor Browser causes black pages to be displayed in white anyway. The extension is already set to black on all settings. They developed the extension like Apple did with "sunrises and sunsets". If I now want to achieve that all pages are displayed in black in a dark mode and that permanently, I get a problem. In other words, if a trained photographer needs to see the Internet white and then hours later sees it black, you can imagine that he struggles with that. You can set up the whole macOS to be permanently black with extensions from the App Store and Github. Even the Safari browser. As I said, I can't judge Mozilla Firefox because I've never used it. I don't know Windows and Firefox. But I know macOS and Tor Browser. There is a hole in your software's source code that Tor Browser doesn't fix. It doesn't matter whether the extension now also requests the location because of the time and thus the brightness. In the configuration it must be possible to set the extension to permanently "black" on Firefox and Tor Browser. There is no such thing as "twilight" in websheets. Attached are three screenshots from Tor Browser.

If he doesn't, there's no more option. As a comparison on the same system: macos Safari browser with an app from the "Nightlight" app store. The error rate there is almost 0%. There is always - on all systems - the problem of the DNS cache on the computer. It strikes me again and again that it (meaning the OS) shows the same thing again. It is neither on the Internet nor on the apps or the caches of the apps, but in the DNS cache of the operating system. You can clean this up under macOS with Linux Shell commands under Terminal and lo and behold, there are no more reminders of the style sheets of the pages when you call them up (including the color where the extension apparently had access to).

Tor Browser Extension  Overview Tor Browser Extension Configuration Mozilla (Tor Browser) Configuration Options Appearance