skhzhang / time-based-themes

Automatically change Firefox's theme based on the time
MIT License
121 stars 13 forks source link

Change themes based on the system theme not working on Ubuntu Linux #42

Open nose-gnome opened 1 year ago

nose-gnome commented 1 year ago

Description When Change themes based on system theme is enabled, the extension will change the browsers theme to the specified nighttime theme, even if the system theme is in light mode. This means that the browser theme will continue using nighttime theme indefinitely, regardless of system theme

System Information

Steps To Reproduce Steps to reproduce the behaviour:

  1. Go to preferences
  2. Click on Change themes based on system theme
  3. See error: After a few seconds theme will change to nighttime (ignoring system theme)

Expected behaviour Theme changes immediately to match system theme, and continue to match system theme whenever system theme changes

Additional context add-on version: 1.4.1

snpefk commented 1 year ago

Same on Manjaro Linux with Gnome 43.3

girlmaya commented 1 year ago

31 is still not fully fixed. On both my systems, only the first time the system theme changes does it change the browser theme. Restarting the browser allows the sync to happen the next time the system theme changes.

It doesnt set the theme on browser launch.

Tested on:

Both on latest automaticDark 1.4.1

Edit: might deserve yet another issue. seems like different behavior to the issue above - the theme sync is always accurate, just not triggered more than once

KierPrev commented 1 year ago

Same on Kubuntu 23.04