skick1234 / DisTube

A powerful Discord.js module for simplifying music commands and effortless playback of various sources with integrated audio filters.
https://distube.js.org
MIT License
422 stars 94 forks source link

Proxy feature #33

Closed DopeDealers closed 3 years ago

DopeDealers commented 3 years ago

Is your feature request related to a problem? Please describe. No problem

Describe the solution you'd like the option inside the constructor to use a PROXY i.e {proxy: ""} etc, and then use the proxy arg inside of youtube-dl

Describe alternatives you've considered i was just gonna fork this and do it myself, but i figured id ask if possible to add this before i went ahead!

Additional context Add any other context or screenshots about the feature request here.

skick1234 commented 3 years ago
  1. You can do it by changing <DisTube>.requestOptions

  2. I added and removed this features because it's not necessary and many people think they can use public proxies .-. https://github.com/skick1234/DisTube/commit/f02949b2f403bf63fbddf0a6d3457f22253ec005

DopeDealers commented 3 years ago

i see, well thanks for the quick response

skick1234 commented 3 years ago

I'll close this because it will be not implemented.