search

skick1234 / DisTube

A powerful Discord.js module for simplifying music commands and effortless playback of various sources with integrated audio filters.
https://distube.js.org
MIT License
423 stars 94 forks source link

Features Request #91

Closed LackyPal closed 3 years ago

LackyPal commented 3 years ago

Support for direct stream url, discord attachment links

skick1234 commented 3 years ago

Beta support it

LackyPal commented 3 years ago

It's playing but not giving all song details, i tried to play the following link https://radioindia.net/radio/mirchi98/icecast.audio, it giving me error DiscordAPIError: Invalid Form Body embed.thumbnail.url: Scheme "null" is not supported. Scheme must be one of ('http', 'https'). at RequestHandler.execute (/app/node_modules/discord.js/src/rest/RequestHandler.js:154:13) at runMicrotasks (<anonymous>) at processTicksAndRejections (internal/process/task_queues.js:95:5) at async RequestHandler.push (/app/node_modules/discord.js/src/rest/RequestHandler.js:39:14)

LackyPal commented 3 years ago

It didn't emit playsong

skick1234 commented 3 years ago

It's playing but not giving all song details, i tried to play the following link https://radioindia.net/radio/mirchi98/icecast.audio, it giving me error DiscordAPIError: Invalid Form Body embed.thumbnail.url: Scheme "null" is not supported. Scheme must be one of ('http', 'https'). at RequestHandler.execute (/app/node_modules/discord.js/src/rest/RequestHandler.js:154:13) at runMicrotasks (<anonymous>) at processTicksAndRejections (internal/process/task_queues.js:95:5) at async RequestHandler.push (/app/node_modules/discord.js/src/rest/RequestHandler.js:39:14)

Thumbnail is null embed.thumbnail.url. Because it's direct link :/

LackyPal commented 3 years ago

I tried with distube bot too, its just didn't respond. For discord attachment links, it's saying url not supported

skick1234 commented 3 years ago

I tried with distube bot too, its just didn't respond. For discord attachment links, it's saying url not supported

DisTube Bot doesn't support direct link at the moment

LackyPal commented 3 years ago

I think this is happening because it didn't find the thumbnail, i set the song thumbnail as embed image in playsong event You can add a additional thumbnail , it the song don't have any thumbnail this will be used

skick1234 commented 3 years ago

I think this is happening because it didn't find the thumbnail, i set the song thumbnail as embed image in playsong event You can add a additional thumbnail , it the song don't have any thumbnail this will be used

I said that above https://github.com/skick1234/DisTube/issues/91#issuecomment-847580857

skick1234 commented 3 years ago

And the docs said it can be null. Your problem is not handling it image

LackyPal commented 3 years ago

Sorry, i didn't check it correctly

skick1234 commented 3 years ago

Sorry, i didn't check it correctly

You should join DisTube support server for faster and easier support.

LackyPal commented 3 years ago

Actually i joined it many times before, but i forget to post on discord😅