skiedude / evestructures

An ESI/SSO backed website enabling Eve Online Corporations to view and manage all their owned Structures in New Eden
https://structures.eveskillboard.com
MIT License
22 stars 12 forks source link

No fracture notifications for manual fractures #18

Closed paulipa closed 5 years ago

paulipa commented 5 years ago

When we manually fracture the moons before the autofracture happens we do not seem to get a fracture notification on discord an the moon doesnt seem to get added to the fracture_notices table at all. Is there something wrong in our setup or is this a design for some reason?

skiedude commented 5 years ago

if($diff_manual->days == 0 && $diff_manual->h <= 1 && $diff_manual->invert == 1 && !is_null($notification->extraction_webhook)) { if(is_null($fracture_notice) || $fracture_notice->notice == FALSE) {

So this is the logic around Manual fracture notifications. There is nothing in the extraction API that says When a manual fracture was done. So my logic says

If the the time left before it fractures is equal to or less than 1 hour, and its not in the past already, then we make sure you have saved an extraction webhook, and that we haven't sent a notice already.

So have you done the following:

  1. Extraction webhook is saved for the character who is providing that structure
skiedude commented 5 years ago

So the notification should come within an hour of when the chunk arrives and it could be manually fractured.

skiedude commented 5 years ago

Were you by chacne using slack webhooks?

paulipa commented 5 years ago

Aright thx. We are using discord hooks. But this clears things up, when we see the notification show up we know that we can then pop it instead of assuming notification to show up at autofracture instead.

skiedude commented 5 years ago

So were you getting notifications? just not when you were expecting them?

paulipa commented 5 years ago

Yeah we are getting notifications indeed but not just when we expected them ^^

skiedude commented 5 years ago

ah ok! yeah I really need to make a FAQ, the automatic fractures notifications will be clsoe to 3 hours after the arrival time