search

skifaster / supertags

MIT License
3 stars 2 forks source link

Tags with non latin chars #1

Closed Lurk closed 9 years ago

Lurk commented 9 years ago

Regular expression [a-z\d-]+ does not match the tag is not written in English. Replace it with a regular expression from twttr.txt (https://github.com/twitter/twitter-text/blob/master/js/twitter-text.js#L131).

Now superTag understand any language.

skifaster commented 9 years ago

Awesome! Merged in. I'll push to atmosphere shortly.

Lurk commented 9 years ago

@skifaster Looks like it broke tests. But I can`t figure out where (

skifaster commented 9 years ago

@Lurk there was a context issue in the test, i fixed that. The tests are passing locally now, but shippable is still complaining ... I'll remove that test case for now, since it is passing locally.

here is the stack trace:

expected 'most' to equal 'пример'
AssertionError: expected 'most' to equal 'пример'
    at /home/shippable/.nvm/v0.10.25/lib/node_modules/chai/lib/chai/assertion.js:111
    at assertEqual (/home/shippable/.nvm/v0.10.25/lib/node_modules/chai/lib/chai/core/assertions.js:447)
    at /home/shippable/.nvm/v0.10.25/lib/node_modules/chai/lib/chai/utils/addMethod.js:40
    at /home/shippable/workspace/src/github.com/arsnebula/supertags/test/tests/parse-and-apply.test.js:79
    at runStep (/home/shippable/.nvm/v0.10.25/lib/node_modules/casperjs/modules/casper.js:1553)
    at checkStep (/home/shippable/.nvm/v0.10.25/lib/node_modules/casperjs/modules/casper.js:399)