search

skiff-org / skiff-windows-app

Skiff's Windows app for privacy-first, end-to-end encrypted Mail, Drive, Calendar, and Pages.
https://skiff.com
GNU Affero General Public License v3.0
108 stars 70 forks source link

Added notification counter badge to app taskbar icon #11

Closed Novack closed 11 months ago

Novack commented 11 months ago

Typical Windows taskbar icon counter badge functionality. image

Novack commented 11 months ago

Looks like the standard icon is missing, but the overlay is working... If you tweaked something in the resources, maybe the skiff logo got removed (see image). image

Otherwise, maybe the TaskbarItemInfo needs some other parameter on Windows 11 (Im still on Win10, thus I didn't noticed). If this is the case, I'll investigate!

Novack commented 11 months ago

NVM. Looks good.

Ahh cool then, great, thanks :)

amilich commented 11 months ago

Skiff Installer.msi.zip New MSI. Let me know if this looks good. Installer should install over existing version.

Novack commented 11 months ago

Btw, the unread counter gives false readings as you move through the different folders, but is related to the messages received. Is there another message for the current folder that I can use to filter out the counter if not Inbox?.

amilich commented 11 months ago

Great point. I can make it just send inbox unread count?

Novack commented 11 months ago

Great point. I can make it just send inbox unread count?

That would be ideal I think!

amilich commented 11 months ago

Great point. I can make it just send inbox unread count?

That would be ideal I think!

Cool. I'll ticket it. The MSI should still be fine.

Novack commented 11 months ago

Skiff Installer.msi.zip New MSI. Let me know if this looks good. Installer should install over existing version.

image Maybe project version needs increase?

amilich commented 11 months ago

Will try that

amilich commented 11 months ago

Skiff Installer.msi.zip Should be upgraded to 1.0.8

riverar commented 11 months ago

Good start! I think we should consider maybe upgrading this in the future to using the OS provided badging facilities for a more native look/feel. In general, I think we should consider using OS native features over anything homegrown when adding features to this app (i.e. the non-standard notifications should be replaced too).

Novack commented 11 months ago

Skiff Installer.msi.zip Should be upgraded to 1.0.8

Worked perfectly!

Novack commented 11 months ago

Good start! I think we should consider maybe upgrading this in the future to using the OS provided badging facilities for a more native look/feel. In general, I think we should consider using OS native features over anything homegrown when adding features to this app (i.e. the non-standard notifications should be replaced too).

Hey there. This is using Windows.TaskbarItemInfo.Overlay, is not a custom solution other than rendering the counter on top. Works from Win7 onwards. Do you know of better alternatives?

riverar commented 11 months ago

We may want to consider giving the app identity and using WinRT APIs such as the BadgeUpdateManager and AppNotificationManager. It's more plumbing work to get this all set up though so I'm not suggesting any immediate change here.