search

skiff-org / skiff-windows-app

Skiff's Windows app for privacy-first, end-to-end encrypted Mail, Drive, Calendar, and Pages.
https://skiff.com
GNU Affero General Public License v3.0
108 stars 70 forks source link

Support dark theme on title bar #6

Open AlpyneDreams opened 1 year ago

AlpyneDreams commented 1 year ago

Pretty essential feature. Should fail gracefully on Windows versions that are too old for dark theme.

Currently this hooks into localStorage, but if you want to send the message manually from the web app code you can revert 550d987848f55280a5e182941911facbb5721cc1.

amilich commented 1 year ago

If you're ok with it, I might just add a postMessage with the theme. We can get that out today. It seems more consistent.

riverar commented 1 year ago

Just waking up on the West Coast please don't merge this until I've provided some comments. This has OS version implications and cannot be used as is.

AlpyneDreams commented 1 year ago

Ready for review again. I can modify it to use CsWin32 for DwmSetWindowAttribute if that's preferred.

amilich commented 1 year ago

If you're ok with it, I might just add a postMessage with the theme. We can get that out today. It seems more consistent.

Noting this is out in production.

AlpyneDreams commented 12 months ago

Now the messaging is out in production, is there anything left blocking this PR from being merged or are we just waiting for review? I'm happy to make changes if any are needed.

amilich commented 11 months ago

Now the messaging is out in production, is there anything left blocking this PR from being merged or are we just waiting for review? I'm happy to make changes if any are needed.

Awesome. Should I go ahead and test anything in particular? I can build/release in the next day

AlpyneDreams commented 11 months ago

Now the messaging is out in production, is there anything left blocking this PR from being merged or are we just waiting for review? I'm happy to make changes if any are needed.

Awesome. Should I go ahead and test anything in particular? I can build/release in the next day

Not really, just that the titlebar matches the current theme and that "auto" respects the user's theme preference.