search

skiffos / SkiffOS

Any Linux distribution, anywhere.
https://skiffos.com
MIT License
685 stars 50 forks source link

VisionFive2: Use docker recommended kernel config #309

Closed maxberger closed 5 months ago

maxberger commented 6 months ago

Config was created using the helper script from https://github.com/moby/moby/raw/master/contrib/check-config.sh

paralin commented 6 months ago

@maxberger if you enable apps/docker all of this will be enabled as well.

Is there some reason to include this in the base config? In general we try to keep the base config minimal and add the necessary bits for docker when enabling docker. Thanks!

maxberger commented 6 months ago

Interestingly the settings where not included for me when I tried building (2024.1 tag), this is why I added them.

One reason could be that they are excplicitly set to be unset in

https://github.com/skiffos/SkiffOS/blob/master/configs/starfive/common/kernel/base

Could that be an issue? Then I would only re-add the ones that are unset in that file

paralin commented 6 months ago

The settings are merged using the kernel merge_config.sh - config packages that appear later in SKIFF_CONFIG override those earlier in the list. As long as apps/docker appears after starfive/visionfive2 on the list, it should override those settings.

Maybe some are missing in apps/docker? Or some prerequisites are not enabled?

You can check by using "make linux-menuconfig" in the workspace directory and then going to one of the options that isn't set properly (press / then search for it) and it will tell you which prerequisites are missing.

paralin commented 5 months ago

@maxberger this should be fixed now! thanks.

maxberger commented 5 months ago

@maxberger this should be fixed now! thanks.

Thanks! Sorry for not following up with this.