search

skift-org / skift

🥑 A modern delightful operating system
https://skiftos.org/
GNU Lesser General Public License v3.0
2.36k stars 130 forks source link

fix str used to check for double question mark equals token in vaev-js #428

Closed JakeChampion closed 3 months ago

sleepy-monax commented 3 months ago

Nice catch! 👍

sleepy-monax commented 3 months ago

Oops, I merged that too soon. This code worked as expected; we were preventing the compiler from interpreting ??= as a trigraph. https://en.cppreference.com/w/cpp/language/operator_alternative

JakeChampion commented 3 months ago

Oh! Which version of c++ are we using? Trigraphs were removed in 17 I think

sleepy-monax commented 3 months ago

@JakeChampion C++23, but looks like Clang is still interpreting them