search

skillachie / finsymbols

Obtains stock symbols and relating information for SP500, AMEX, NYSE, and NASDAQ
110 stars 41 forks source link

removed explicit encoding #12

Closed jwfu closed 8 years ago

jwfu commented 8 years ago

Python 3 appears to be able to parse the strings without explicit encoding. When I ran finsymbols.get_sp500_symbols() in Jupyter with Python 3, each value in the dict pair was byte encoded. By removing encode from the get_sp500_symbols() method, everything comes out as expected.

skillachie commented 8 years ago

Thanks Jun. I will run the tests in a Python3 environment and merge in a few

skillachie commented 8 years ago

Hi Jun,

The explicit encoding was more than likely done for Python 2.X. I could not reproduce the issue you mentioned above also.

screen shot 2016-04-27 at 4 50 09 am
skillachie commented 8 years ago

Hi Jun,

Thanks for the push. I was able to reproduce it while writing a simple test case to check. Merged the pull request and will push an updated package