skillachie / finsymbols

Obtains stock symbols and relating information for SP500, AMEX, NYSE, and NASDAQ
110 stars 41 forks source link

removed duplicate line and enhanced parsing cvs format #15

Closed Wesseldr closed 7 years ago

Wesseldr commented 8 years ago
  1. Removed duplicate line:

symbol_data_dict['industry'] = row[7]

  1. Using cvs.reader. Now we can also have company names with , inside their name like "1-800 FLOWERS.COM, Inc." By using the cvs reader we can also drop the workaround line:

symbol_data = symbol_data.replace('"', "")

Hope this helps :-)

Wesseldr commented 8 years ago

Please check the tests, I had to change a length error on the s&p of 504 into 505 with seems odd to me.

skillachie commented 8 years ago

Thanks Wessel. Will check and merge over the weekend