SDU-794 Odoo client and models.

skilld-labs / go-odoo

Golang wrapper for Odoo API

Apache License 2.0

86 stars 62 forks source link

SDU-794 Odoo client and models. #30

Closed boguslaw-wojcik closed 3 years ago

ahuret commented 3 years ago

Hi @boguslaw-wojcik ! Sorry, I didn't have time these days for reviewing... I wonder why you closed this PR, at a first eye it look nice ? :-)

boguslaw-wojcik commented 3 years ago

Hi @ahuret ! I've created this PR by mistake after making a fork of your repository. It removes pre-generated models and changes readme to include a go run command to generate models without installing it globally. But it's not necessarily what you want. If you think you want this change I can create another PR. Besides that there is a small change I made to the generation templates that I think could be useful for others, I will make another PR this evening. Cheers and big kudos and thank you for this library. It really saved me a lot of hassle!

ahuret commented 3 years ago

There is globally a (big ?) work to do to keep this library in a good golang way. (go modules / go generate?)

What I think:

https://github.com/skilld-labs/go-odoo could contains "generic" odoo models (with support of multiple versions ? / subdirectories ?). It should be usable as a standard go module.
If you want specific / custom models, fork the instance, and generate your models.

What do you think ?

I'd be happy to get an eye on your PR !