search

skilld-labs / go-odoo

Golang wrapper for Odoo API
Apache License 2.0
86 stars 62 forks source link

authenticate() : interface conversion: interface {} is bool, not int64 #31

Closed edouard-claude closed 2 years ago

ahuret commented 2 years ago

Hello @edouard-claude , thank you for your contribution ! We could probably add an error errClientAuthentication with message like client authentication error: please verify client configuration and return it when resp is a false boolean. Btw, for me no need to explicitly set c.auth = false since it's already false

What do you think ?

edouard-claude commented 2 years ago

Hello @ahuret, yes i agree, i had to write this fix quickly, my customer changed his credentials to warn me 😅 i didn't think about the right way to make the return clearer.

ahuret commented 2 years ago

No problem ! You can make this changes and I'll merge it :) Thx again