skilld-labs / kaizen

Basic theme
8 stars 0 forks source link

Kaizen 2.0 #144

Closed koskinpark closed 2 years ago

koskinpark commented 2 years ago

❗❗❗Major updates :

⚠⚠⚠ Minor updates :]

To be known for frontender Added three helpers into @skilld/kaizen-core:

  1. entity-fake-link
  2. focus-visible
  3. root-variables

entity-fake-link - we had it before, but now it was moved to @skilld/kaizen-core package. It is script for simulating link on the wrapper. For example when you want to have a whole teaser clickable, instead of only title as link. Check sources how it works https://github.com/skilld-labs/kaizen/blob/kaizen-updates/packages/kaizen-core/helpers/entity-fake-link/h-entity-fake-link.js#L42

focus-visible - helper which improves visual experience for css's :focus & keeps accessibility, more info here: https://www.npmjs.com/package/focus-visible

root-variables - littler script which puts two css variables into html tag with viewport width and viewport height calculations. It's useful for Safari browser on iOS devices where default min-height: 100vh; and min-width: 100vw can work unexpected. Here script helps.

Remains to be done

  1. Provide screenshot.png in @skilld/kaizen-tg, to have screenshot on drupal's appearance page. It can be done in the follow-up, so it's not really blocking this PR.
  2. Deep review of this PR from all of you. Share your eyes / opinions / feedbacks about what should be done else.
  3. Merge PR
  4. Update on npm
  5. Well test of all these
  6. ... new task to fix bugs ?
  7. ... release of 2.0.0

Offtop kaizen's logotype change? Like Kaizen 2.0, i don't know. You suggest )