Clean could remove .env

skilld-labs / skilld-docker-container

Starterkit for drupal development

MIT License

20 stars 32 forks source link

Clean could remove .env #337

Closed andypost closed 3 years ago

andypost commented 3 years ago

Removal of .env and docker/docker-compose.override.yml will prevent using outdated ones

YurkinPark commented 3 years ago

Not cool, i'm changing this stuff usually (to run localy with traefik) and this removing will break my changes (especially for docker-compose.override.yml)

andypost commented 3 years ago

@YurkinPark do you using make clean?

andypost commented 3 years ago

Looks everyone disagree to kill overrides on clean, so maybe separate goal to clean-up overrides makes sense

davidferlay commented 3 years ago

I'm thinking about 2 things :

make reset could indeed reset these files (and maybe be part of make clean)
Also we can improve make info to warn user about changes in these files

gaydabura commented 3 years ago

I'm thinking about 2 things :

make reset could indeed reset these files (and maybe be part of make clean)

You may just delete full folder and re-clone again @davidferlay

andypost commented 3 years ago

@gaydabura on other hand no reason to re-clone repo when there's git clean -f