skilld-labs / skilld-docker-container

Starterkit for drupal development
MIT License
20 stars 32 forks source link

Remove profile from phpcs checking #416

Closed ilyano closed 2 years ago

ilyano commented 2 years ago

We have web/profiles/*.* and web/profiles/contrib/ folders in .gitignore file, but still check web/profiles/$(PROFILE_NAME) in phpcs job.

Locally it's ok, because we use to run phpcs only before pushing update, but in .gitlab-ci.yml we have phpcs job running before web/profiles is even created. And due to docker is run as root, then it creates folder, which can't be removed by other jobs in pipeline.

So, I think, that we should remove this folder from phpcs checking, because it's not in repository.