skilld-labs / skilld-docker-container

Starterkit for drupal development
MIT License
20 stars 32 forks source link

Move to compose v2 before June'23 #436

Closed andypost closed 8 months ago

andypost commented 1 year ago

There's things to update

Details https://www.docker.com/blog/new-docker-compose-v2-and-v1-deprecation/

nicolas-guerrier commented 1 year ago

On my last fresh Fedora install, I use only docker compose plugin and created a shell script in /usr/local/bin/docker-compose, containing :

#! /bin/sh
docker compose "$@"

Got no issue with SDC installs so far, so I guess it gonna be easy to move on with docker compose plugin.

nicolas-guerrier commented 1 year ago

Regarding Readme, I didn't update it yet. I guess we need to add a "Dependencies" section (not only about docker[-]compose but also make etc.) before "Quickstart".

Another thought : for BC purpose, we may add some code in Makefile to detect if compose plugin exists & wrap the calls with it, with right version.

Or, if we want to keep Makefile "clean" : copy a shell script (like the one i described above) in $HOME/.local/bin (unsure about compatibility on different installs (Mac? ;)) though)

andypost commented 1 year ago

I think checking of old binary could be done but may affect performance as there's sub-make calls which will restart this detection

++ to describe dependencies.

andypost commented 1 year ago

About MacOS we already using comments but some of it could be moved to readme like

andypost commented 1 year ago

https://developers.redhat.com/articles/2023/05/23/podman-desktop-now-generally-available

GA of podman announced

andypost commented 8 months ago

Filed upgrade of manifest https://github.com/skilld-labs/skilld-docker-container/issues/451