search

skilld-labs / skilld-docker-container

Starterkit for drupal development
MIT License
20 stars 32 forks source link

Remove dependency to Webmozart\PathUtil\Path #438

Closed nicolas-guerrier closed 1 year ago

nicolas-guerrier commented 1 year ago

Lastly, fresh installs are failing with next message : 

docker-compose exec -T --user 1000:1000 php  composer create-required-files
> SkilldDrupal\composer\ScriptHandler::createRequiredFiles

In ScriptHandler.php line 81:

  [Error]                                    
  Class "Webmozart\PathUtil\Path" not found  

Exception trace:
  at /var/www/html/scripts/composer/ScriptHandler.php:81
 SkilldDrupal\composer\ScriptHandler::createRequiredFiles() at phar:///usr/bin/composer2/src/Composer/EventDispatcher/EventDispatcher.php:439
 Composer\EventDispatcher\EventDispatcher->executeEventPhpScript() at phar:///usr/bin/composer2/src/Composer/EventDispatcher/EventDispatcher.php:257
 Composer\EventDispatcher\EventDispatcher->doDispatch() at phar:///usr/bin/composer2/src/Composer/EventDispatcher/EventDispatcher.php:129
 Composer\EventDispatcher\EventDispatcher->dispatchScript() at phar:///usr/bin/composer2/src/Composer/Command/ScriptAliasCommand.php:74
 Composer\Command\ScriptAliasCommand->execute() at phar:///usr/bin/composer2/vendor/symfony/console/Command/Command.php:298
 Symfony\Component\Console\Command\Command->run() at phar:///usr/bin/composer2/vendor/symfony/console/Application.php:1040
 Symfony\Component\Console\Application->doRunCommand() at phar:///usr/bin/composer2/vendor/symfony/console/Application.php:301
 Symfony\Component\Console\Application->doRun() at phar:///usr/bin/composer2/src/Composer/Console/Application.php:377
 Composer\Console\Application->doRun() at phar:///usr/bin/composer2/vendor/symfony/console/Application.php:171
 Symfony\Component\Console\Application->run() at phar:///usr/bin/composer2/src/Composer/Console/Application.php:141
 Composer\Console\Application->run() at phar:///usr/bin/composer2/bin/composer:88
 require() at /usr/bin/composer2:29

create-required-files [--dev] [--no-dev] [--] [<args>...]

make: *** [Makefile:94: back] Error 1

Same issue has been documented here : https://github.com/drupal-composer/drupal-project/issues/618

And same solution could be applied to scripts/composer/ScriptHandler.php.

andypost commented 1 year ago

I think we should clean-up our custom scripts/composer/ScriptHandler.php as useless in favour of core's scaffolding https://www.drupal.org/docs/develop/using-composer/using-drupals-composer-scaffold