Gulp clone taks instead drush zen command. Cleanup unsed zen theme files - Githubissues

skilld-labs / zen

Fork of Drupal Zen theme https://www.drupal.org/project/zen

1 stars 5 forks source link

Gulp clone taks instead drush zen command. Cleanup unsed zen theme files #22

Closed andriyun closed 7 years ago

andriyun commented 7 years ago

How to check:

install fresh drupal
cd themes
drush en components -y
git clone git@github.com:skilld-labs/zen.git && cd zen && git checkout gulp-clone-task
cd zen
docker run --name zen-container --rm -v $(pwd):/work -v $(pwd)/../gulpclone:/gulpclone -it skilldlabs/frontend:zen sh -c 'npm i gulp-regex-rename yargs && gulp --theme_name gulpclone'
drush en gulpclone -y
drush config-set system.theme default gulpclone -y
check what theme works correctly and has not errors in dblog reports

hog-seruj commented 7 years ago

It's work for me. I installed subtheme with this changes in Macif project.

hog-seruj commented 7 years ago

I see several lint errors:

FILE: /work/themes/macif_theme/macif_theme.theme

FOUND 4 ERRORS AFFECTING 4 LINES

52 | ERROR | [x] Short array syntax must be used to define arrays | | (Drupal.Array.DisallowLongArraySyntax.Found) 53 | ERROR | [x] Short array syntax must be used to define arrays | | (Drupal.Array.DisallowLongArraySyntax.Found) 56 | ERROR | [x] Short array syntax must be used to define arrays | | (Drupal.Array.DisallowLongArraySyntax.Found) 60 | ERROR | [x] Short array syntax must be used to define arrays | | (Drupal.Array.DisallowLongArraySyntax.Found)

PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY

FILE: /work/themes/macif_theme/README.txt

FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE

106 | WARNING | Line exceeds 80 characters; contains 118 characters | | (Drupal.Files.TxtFileLineLength.TooLong)

FILE: /work/themes/macif_theme/theme-settings.php

FOUND 3 ERRORS AFFECTING 3 LINES

19 | ERROR | [x] Short array syntax must be used to define arrays | | (Drupal.Array.DisallowLongArraySyntax.Found) 23 | ERROR | [x] Short array syntax must be used to define arrays | | (Drupal.Array.DisallowLongArraySyntax.Found) 27 | ERROR | [x] Short array syntax must be used to define arrays | | (Drupal.Array.DisallowLongArraySyntax.Found)

PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY

Time: 105ms; Memory: 6Mb

andriyun commented 7 years ago

Moved report to separate issue https://github.com/skilld-labs/zen/issues/26

andypost commented 7 years ago

FYI https://www.mediacurrent.com/blog/mediacurrents-drupal-theme-generator

andriyun commented 7 years ago

Thanks for the link @andypost

Do we have anything that blocks us to merge this pull request?