search

skillrecordings / egghead-next

The frontend for egghead.io.
https://egghead.io
Other
1.41k stars 193 forks source link

Links in `about` section in footer don't link correctly. #1030

Closed lsminter closed 2 years ago

lsminter commented 2 years ago

The links in the about section, right side in the footer, don't link correctly and I've done some digging.

If a user is logged out, all of the links work correctly but if a user is logged in, they aren't. The issue comes from the Pricing link not being displayed when the user is logged in and the user is a member. The links get offset so that Store links to Pricing, Support links to Store, Log Out links to support@egghead.io, and there is no Log Out button.

If I log out then log back in, the links are fixed but if I refresh the page they get messed up again.

It works just fine when logged in locally. It's just messed up live.

lsminter commented 2 years ago

Here is a loom I recorded with Zac on the issue: https://www.loom.com/share/ad983f9c13c844eb8c2f48111fa1dfc6

zacjones93 commented 2 years ago

Can't reproduce locally. The fact that the component renders 15+ times seems like an issue to investigate.

ltclmbdev commented 2 years ago

fixed via https://github.com/eggheadio/egghead-next/pull/1038