search

skills / github-pages

Create a site or blog from your GitHub repositories with GitHub Pages.
MIT License
682 stars 173 forks source link

Bug Report: Missing Mention of GitHub Pages Link #82

Open hariskhan-hk opened 1 year ago

hariskhan-hk commented 1 year ago

Description The instructions in step 5 of the activity guide do not mention or explain the GitHub Pages link. Users are left without guidance on how to access their published blog post on the GitHub Pages site after merging changes.

Steps to Reproduce

  1. Follow the activity guide for creating a blog post and merging changes.
  2. Note that step 5 does not provide the GitHub Pages link or instructions.

Expected Behavior The activity guide should include a clear mention and explanation of the GitHub Pages link for accessing the published blog post.

Actual Behavior Step 5 of the activity guide does not mention or explain the GitHub Pages link, causing confusion for users trying to view their published blog post.

Suggested Solution Update the activity guide to include the GitHub Pages link and provide instructions on accessing the published blog post after merging changes.

cmwilson21 commented 1 year ago

@hariskhan-hk Thanks for opening an issue! Are you suggesting we add a link to this step?

And what Pages link are you suggesting?

We are in the process of updating all Skills courses and their content. We appreciate your feedback! 💛

jahway603 commented 1 year ago

This is a duplicate of Issue https://github.com/skills/github-pages/issues/73

nevinnoby commented 1 year ago

https://github.com/skills/github-pages.git

sinsukehlab commented 1 year ago

The GitHub Pages site link is explained in Step 1. Should we add similar explanation to Step 5?

  1. Wait about one minute then refresh this page (the one you're following instructions from). GitHub Actions will automatically update to the next step.

    Turning on GitHub Pages creates a deployment of your repository. GitHub Actions may take up to a minute to respond while waiting for the deployment. Future steps will be about 20 seconds; this step is slower. Note: In the Pages of Settings, the Visit site button will appear at the top. Click the button to see your GitHub Pages site.

Zhongzhou commented 3 months ago

This definitely should be added to Step 5 instead of (or in addition to) Step 1.