skills / introduction-to-github

Get started using GitHub in less than an hour.
MIT License
4.38k stars 1.9k forks source link

[Bug] Broken Images in Steps 2 and 3 #731

Closed JDPaiva1 closed 4 months ago

JDPaiva1 commented 4 months ago

Summary

In the activity section for steps 2 and 3, some images are not displaying correctly due to an quotation mark at the end of the image URL. This issue affects the following images:

https://github.com/skills/introduction-to-github/blob/86a4beabd429a43f345e87c8116b6f30f0ad7af0/.github/steps/2-commit-a-file.md?plain=1#L36

https://github.com/skills/introduction-to-github/blob/86a4beabd429a43f345e87c8116b6f30f0ad7af0/.github/steps/2-commit-a-file.md?plain=1#L40

https://github.com/skills/introduction-to-github/blob/86a4beabd429a43f345e87c8116b6f30f0ad7af0/.github/steps/3-open-a-pull-request.md?plain=1#L30

How to reproduce

  1. Go to step 2 or 3
  2. Scroll down to the activity section
  3. See error

image

image

Tc69Cabusog commented 4 months ago

How

On Sat, May 18, 2024, 12:08 AM Grace Park @.***> wrote:

Closed #731 https://github.com/skills/introduction-to-github/issues/731 as completed via #732 https://github.com/skills/introduction-to-github/pull/732.

— Reply to this email directly, view it on GitHub https://github.com/skills/introduction-to-github/issues/731#event-12850672969, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6N6QFQFPQVXPF42RVOVUKDZCYTRFAVCNFSM6AAAAABHSAJKP6VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHA2TANRXGI4TMOI . You are receiving this because you are subscribed to this thread.Message ID: <skills/introduction-to-github/issue/731/issue_event/12850672969@ github.com>