search

skills / publish-packages

Use GitHub Actions to publish your project to a Docker image.
MIT License
157 stars 71 forks source link

[Bug] Using deprecated input for docker/build-push-action@v1 #17

Closed chadfawcett closed 1 year ago

chadfawcett commented 1 year ago

Describe the bug During testing of the course I noticed there was a warning annotation saying the workflow is using a deprecated input for docker/build-push-action@v1

To Reproduce Steps to reproduce the behavior:

  1. Get to step 4 in the course
  2. Click on Actions in the top nav
  3. Select the latest run of Publish to docker
  4. Scroll down to Annotations
  5. See warning

Expected behavior A workflow run without warning/error annotations

Screenshots If applicable, add screenshots to help explain your problem.

Screen Shot 2023-02-15 at 3 14 49 PM

Device information

Additional context Workflow should probably be updated to use docker/build-push-action@v2

sinsukehlab commented 1 year ago

I have bumped docker/build-push-action@v1 to v3 in my PR #7 (df35711). Now v4 is available. If you have any suggestion about the workflow template, please give me some advice.

chadfawcett commented 1 year ago

@sinsukehlab I appreciate the effort! I think #7 should just be kept to your README changes though. We don't want to add too many different things to that one PR. Definitely feel free to open a separate PR with the changes necessary to resolve this issue though.

I'm going to try bumping some of my colleagues to see if we can get the README changes merged.

sinsukehlab commented 1 year ago

I have now opened a separate PR #19.