skills / publish-packages

Use GitHub Actions to publish your project to a Docker image.
MIT License
157 stars 71 forks source link

Missing read permissions to repo content #24

Closed ayodejiayodele closed 1 year ago

ayodejiayodele commented 1 year ago

I added the contents: read permissions to the workflow file so that the managed identity can have access to the repo contents on the checkout action step.

Why:

The sample script fails on the first step (checkout) with a permission error without this line.

What's being changed:

permissions:
  packages: write # This is required for requesting the JWT
  contents: read  # This is required for actions/checkout

Check off the following:

cmwilson21 commented 1 year ago

👋 @ayodejiayodele - Thanks for this PR! We'll get it reviewed! ⚡

heiskr commented 1 year ago

We have unfortunately needed to restructure these courses in order to meet updated accessibility requirements. I am closing this pull request but feel free to open another pull request.

ayodejiayodele commented 1 year ago

@heiskr the restructured course would still fail, and no one would be able to use the course as-is. You should consider this as part of the cleanup process 👍