search

skills / publish-packages

Use GitHub Actions to publish your project to a Docker image.
MIT License
157 stars 71 forks source link

[Bug] Misleading instruction #40

Open hectorsector opened 4 months ago

hectorsector commented 4 months ago

Describe the bug Misleading instruction at https://github.com/skills/publish-packages#keyboard-activity-pull-your-image The current highlighted docker image location should be removed, because student might just copy and paste.

To Reproduce Steps to reproduce the behavior:

  1. Perform all the previous activities

Expected behavior Additional instruction to lead student to locate the uploaded package, and copy the correct pull script.

Screenshots For example,

image

Originally opened in: https://github.com/github/skills/issues/72 (internal link only)

mjbear commented 16 hours ago

@hectorsector I guess this one for Step 4 is still open and hasn't had a PR merged without referencing this issue ticket.

Question: The student would have to intentionally type out the incorrect package path, right?

I found the screenshots somewhat helpful, however detailed written steps are probably fine too.

mjbear commented 10 hours ago

@hectorsector :sunglasses: Submitted PR #51