search

skills / publish-packages

Use GitHub Actions to publish your project to a Docker image.
MIT License
157 stars 71 forks source link

[Feature] Distinguish difference between personal (classic) access tokens and fine-grained access tokens #42

Open pvcasillasg opened 4 months ago

pvcasillasg commented 4 months ago

Hey there, in the step to create a personal access token, you should update it to the fine-grained tokens!

Loving this course!

nguyenalex836 commented 3 months ago

@pvcasillasg Hello! 👋 Thank you for taking the time to open an issue!

Hey there, in the step to create a personal access token, you should update it to the fine-grained tokens!

Can you elaborate more on what you mean here? We're glad you are enjoying the course! ✨

pvcasillasg commented 3 months ago

@pvcasillasg Hello! 👋 Thank you for taking the time to open an issue!

Hey there, in the step to create a personal access token, you should update it to the fine-grained tokens!

Can you elaborate more on what you mean here? We're glad you are enjoying the course! ✨

It's kinda weird, but i have never use a personal access token, and I spend some minutes trying to look for those permisions, so maybe you should update the permissions that requiere to set a fine grainer access token.

or just specify which type of access token are you referring in the step, something like this: Pull Request #43

Just for the most newbies that never did something like that before!

Edit:

The 4th step refer to personal access token but there is two Types of personal access token, which can be a bit confusing

nguyenalex836 commented 3 months ago

@pvcasillasg Gotcha! Really appreciate the elaboration here 💛 I'll have the team review this - thanks again for flagging!

pvcasillasg commented 3 months ago

@pvcasillasg Gotcha! Really appreciate the elaboration here 💛 I'll have the review this - thanks again for flagging!

Thanks to you to take my consideration!

mjbear commented 14 hours ago

Based on the written steps and screenshot the only token type that fits is the personal (classic) access tokens. That said the content could call the token type out clearly to eliminate confusion.

mjbear commented 8 hours ago

@pvcasillasg I opened up PR #50 to add details. I'm not sure why your PR got closed, but maybe you needed to fork this repo, create changes, and submit a PR against this repo.

@nguyenalex836 @hectorsector This one is in your court now. :laughing: :basketball: