Fix README.md - Githubissues

skills / publish-packages

Use GitHub Actions to publish your project to a Docker image.

MIT License

157 stars 71 forks source link

Fix README.md #7

Closed sinsukehlab closed 1 year ago

sinsukehlab commented 2 years ago

Change the docker package to pull in Step 4

Why:

Closes #6, Closes #8

What's being changed:

I have changed some instructions mainly in Step 4 so that learners can pull the correct Docker image. :warning: Some screenshots need changing.

Check off the following:

[x] For workflow changes, I have verified the Actions workflows function as expected.
[x] For content changes, I have reviewed the style guide.

sinsukehlab commented 2 years ago

@heiskr @dihydroJenoxide I would appreciate it if you could review this PR at your earliest convenience. Replacing those screenshots that I indicated would be an arduous task, but I would be very grateful if you could improve this PR.

sinsukehlab commented 2 years ago

I would like to open another PR to close #8 after this PR is merged.

wongcyrus commented 1 year ago

The instruction should ask user to get the SHA tag from GitHub Action for Activity: Pull your image

Here is video demo for the step. Demo to get the tag from GitHub Action

sinsukehlab commented 1 year ago

The instruction should ask user to get the SHA tag from GitHub Action for Activity: Pull your image

Here is video demo for the step. Demo to get the tag from GitHub Action

You can get the tag from the Packages heading link. It redirects to the list of packages you have published.

sinsukehlab commented 1 year ago

@chadfawcett I highly appreciate your suggestions. I have committed some suggestions. I have also cherry-picked a commit from another branch.

sinsukehlab commented 1 year ago

I have split this PR. PR #19 changes the YAML code block.

heiskr commented 1 year ago

This looks like a useful set of changes, I'll go ahead and merge but feel free to open additional pull requests.