search

skills / release-based-workflow

Create a release based workflow that is built on the foundations of the GitHub flow
MIT License
121 stars 63 forks source link

[Bug] hotfix-v1.0.1 and fix-game-background branches are missing in step 6 #37

Closed Lerking closed 1 year ago

Lerking commented 1 year ago

Hi,

I'm going through this guide to learn more about the github workflows. Everything is working until step 6. It's stated that both hotfix-v1.0.1 and fix-gam-background branches are prepared. However they are not! Thereby steps 6 and 7 can't be finalized.

FYI It's a great guide and lots of valuable information is being presented in an easy to follow way.

/Lerking

Lerking commented 1 year ago

These are the branches created on the initial repository creation. image

rsese commented 1 year ago

👋 ! I recently updated the course and tested that it works, I'll go through it again to see if I can reproduce the problem you're seeing...

rsese commented 1 year ago

hmm I ran through the course again and was able to complete it with no problems -- are you able to reproduce the issue if you run through the course again?

Lerking commented 1 year ago

I've just tried running it again from scratch. This time on my Linux system - the first run was on a Windows machine. However the result was the exact same. After finalizing step 5, I only have these branches. image

The hotfix-v1.0.1 and fix-game-background branches don't exist and i'm stuck at step 6.

rsese commented 1 year ago

ahhh ok I think I see what happened -- I took a peek since your repo is public, I think the problem was at step 2:

https://github.com/Lerking/test-release-based-workflow/pull/2

if you go through the course 1 one more time, at step 2 we should probably be more specific for this bit:

:keyboard: Activity: Update base.css

  1. Create a new branch and change the body CSS declaration in base.css to match what is below. This will set the page background to black

when you get to this part and create a new branch, can you make sure that you're branching off of main and not release-v1.0? This will make sure that the mechanism we use to keep track of which step you're on is updated correctly.

E.g.:

:keyboard: Activity: Update base.css

  1. Create a new branch off of the main branch and change the body CSS declaration in base.css to match what is below. This will set the page background to black
Lerking commented 1 year ago

I've now run the guide from scratch again. This time making sure to branch of 'main', in step 2! ~~The problem persists. I can see that a new branch have been added 'rsese-37-explicit-branching', but still the 2 branches in question for step 6 are not there. image Could there perhaps be some prerequisites that are needed?~~ It seems that I was a bit too fast there. When I went to see the branches, the hot-fix branch wasn't there. But by the time I got my screenshot tool running, to grab an image, github had updated the branch list. I'll now try running the rest of the guide.

Lerking commented 1 year ago

I managed to finish the course. I agree on your solution to be a bit more specific in step 2 regarding which branch to use as base. Thank you for you help and thanks for a great tutorial on github workflows.

rsese commented 1 year ago

ahh great! sorry again for the friction here but glad you were able to finish the course 🙌

I agree on your solution to be a bit more specific in step 2 regarding which branch to use as base.

will open a PR to clarify what we talked about above 👍

sinsukehlab commented 1 year ago

Duplicate of #11